feat: add an arrays slots macro#7360
Merged
joseph-isaacs merged 13 commits intodevelopfrom Apr 9, 2026
Merged
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/array_slots-macro
branch
from
ecb6bd0 to
b7a1ab9
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Contributor
|
just at a quick glance, I think it is super important that we have documentation that explains what gets generated, instead of having to read to proc macro code |
Contributor
|
Fair, I had to review with an ide to see macro expansions |
Contributor
Author
|
I am happy to add just wanted to see what is was and if this was the right approach? |
connortsui20
approved these changes
Apr 9, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # encodings/fastlanes/public-api.lock # vortex-array/src/arrays/patched/vtable/mod.rs
- Remove unused imports of DictArrayExt, ALPArraySlotsExt where SlotsExt provides the needed methods - Fix base_array() -> inner() rename in fastlanes plugin test - Remove dead downcast_slot function and commented-out code - Fix taplo formatting in workspace Cargo.toml - Regenerate public-api.lock files Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joseph-isaacs
force-pushed
the
ji/array_slots-macro
branch
from
1958408 to
286fdaf
Compare
…-run Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Maturin's _build_wheel parses stdout to find the wheel path, but with RUST_LOG=info, maturin's pep517 tracing output goes to stdout and gets parsed as the wheel filename, causing FileNotFoundError. Adding maturin=warn to RUST_LOG suppresses the info-level log line that breaks the wheel path detection. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a array_slot(VTable) attr macro which can be applied to a slots struct. This gives types access to the slots for an array.
e.g.